Resolve some issues with babel-plugin-ember-template-compilation v2.2.2+
#492
+188
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
fix/babel-plugin-ember-template-compilation-v2.2.2-support
branch
from
e4669d5 to
b59a62a
Compare
|
I tested this out in an v4.12 app with ember-cli-babel v7 and ember-template-imports throws an exception because it expects ember-cli-babel v8. If that isn't a bug (we're not using template-imports in the app itself) I don't think we can release this as a bugfix.. And we weren't planning on releasing v4 yet either.. Edit: I think it's a bug in ember-template-imports which should be fixed by ember-cli/ember-template-imports#236 Discord discussion: https://discord.com/channels/480462759797063690/1239836417950220359 |
Windvis
force-pushed
the
fix/babel-plugin-ember-template-compilation-v2.2.2-support
branch
2 times, most recently
from
01cbeec to
f243124
Compare
Windvis
commented
May 14, 2024
Windvis
commented
May 14, 2024
Windvis
changed the title
babel-plugin-ember-template-compilation v2.2.2babel-plugin-ember-template-compilation v2.2.2+
…2.2` The v2.2.2+ releases breaks our ember-template-imports v3 based setup. We need to update to v4 to fix those and also fix the scope issues we accidentally depended on. ember-template-imports v4 also requires some extra babel configuration to ensure component imports aren't stripped out. This is the same setup that the v2 blueprint uses as well.
Windvis
force-pushed
the
fix/babel-plugin-ember-template-compilation-v2.2.2-support
branch
from
92ce0e0 to
8360be7
Compare
|
(Canary will fail until the fix is merged in ember-source, but we'll just ignore that since it will resolve itself eventually) |
Windvis
deleted the
fix/babel-plugin-ember-template-compilation-v2.2.2-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2.2.2 release breaks our ember-template-imports v3 based setup.
We need to update to v4 to fix those and also fix the scope issues we accidentally depended on.
Draft since it seems to break the storybook setup. We probably need to update that first?Not sure what changed or what the issue was, but storybook seems to work now.Fixes #491
TODO: